Feature/redmine4.0 #112
Feature/redmine4.0 #112
Conversation
# Conflicts: # .travis.yml
* Minor cleanups.
* Fixed crashing bulk generation for previous versions.
* Set allowed failures to only ruby v2.6.1.
|
After testing everything manually, it turned out that some things didn't work as expected. |
|
An exception was raised in our form fields generation because false values passed to include_blank in a Fixed it in #112 |
| @@ -2,4 +2,4 @@ | |||
| .label | |||
| = form.label :activity_id | |||
| .input | |||
| = form.collection_select :activity_id, TimeEntryActivity.applicable(entry.project), :id, :name, {include_blank: !local_assigns[:required]}, disabled: local_assigns[:disabled], required: local_assigns[:required] | |||
| = form.collection_select :activity_id, TimeEntryActivity.applicable(entry.project), :id, :name, { include_blank: local_assigns[:required] }, disabled: local_assigns[:disabled], required: local_assigns[:required] | |||
There was a problem hiding this comment.
This seems odd. Removing the ! changed the logic?
There was a problem hiding this comment.
Does this still work with the old Redmine / Rails versions?
There was a problem hiding this comment.
We have the following two cases:
- Select tag is not required -> include a blank field
- Select tag is required -> no blank field
What has changed is that we can no longer have a required select tag without a blank option.
The reason is that the HTML5 standard requires that behavior and rails 5 adopted it.
This leads to a changing behavior in the 2. case and the closest behavior we can create is imo to always include a blank field in a select tag.
dmartingit
force-pushed
the
feature/redmine4.0
branch
from
aac7c39
to
777fab7
Compare
No description provided.