Improve CAA rdata display #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2022
darnuria
reviewed
Oct 13, 2022
|
@djc, I'm going to let you own this one, I haven't been following the conversation. |
djc
reviewed
Oct 20, 2022
|
@djc, all tests are passing, if you think this is ready, go ahead and rebase into main... |
wuerges
commented
Oct 26, 2022
wuerges
force-pushed
the
improve-caa-records-display
branch
from
a883ad2
to
1299d28
Compare
djc
approved these changes
Oct 29, 2022
|
Nice, thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the CAA RData Display trait.
It adds the examples from the RFC 6844 as test cases and fixes the
fmt::Displayfor theValuestruct.trueissuer_criticalflag as128instead of1.u8.;separator is handled.Value::Unknownas a string, if it is a valid UTF8 string.