Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove named binary #1859

Merged
merged 3 commits into from Dec 19, 2022
Merged

remove named binary #1859

merged 3 commits into from Dec 19, 2022

Conversation

HLFH
Copy link
Contributor

@HLFH HLFH commented Dec 15, 2022

The named binary is a duplicate of the trust-dns binary.
They both take the same path src/named.rs.

People may think having a named binary offers a drop-in replacement with BIND.
But at the same time, it conflicts with BIND and the named binary.
I think Trust-DNS provides enough compatibility by itself with BIND but does not need to provide as well a named binary.

Some users may have installed on their system both BIND and Trust-DNS.
They may want to use or try both for some reasons.
Or they may use BIND only for BIND utilities such as dig, host and nslookup.
On Arch Linux, BIND and the BIND utilities are part of the same package.
And overwriting the named binary would just create an unnecessary conflict.
For example, PowerDNS, another BIND alternative, does not conflict with BIND because it does not provide a named binary.
Trust-DNS is a great brand in the making, and I believe we should promote more the use of the trust-dns binary.

@bluejekyll
Copy link
Member

I left this in place as a backward compatible option since it was the original name that I had (probably poorly) chosen. I think it's been long enough that we can make the change without concern.

@HLFH
Copy link
Contributor Author

HLFH commented Dec 15, 2022

I have just removed the "## DEPRECATED" comment. I think it was for the removed named binary, so I guess this comment is no longer needed.

I have also set target/debug/named to target/debug/trust-dns to avoid issues with the testing suite.

@bluejekyll bluejekyll merged commit 422bbcf into hickory-dns:main Dec 19, 2022
@bluejekyll
Copy link
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants