project: remove refs. to removed 'named' binary #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you don't mind, I think it makes sense to clean these things up... for the |
Works for me :-) I'll update ASAP. |
cpu
force-pushed
the
cpu-1859-follow-ups
branch
from
487f0c8
to
13d7326
Compare
cpu
force-pushed
the
cpu-1859-follow-ups
branch
from
4aafcc7
to
6c2f830
Compare
bluejekyll
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
I noticed the README references a
namedbinary that was removed in #1859 in favour of usingtrust-dns. This branch is my attempt to clean up a few remaining references like this.I've split each edit into its own commit in case you prefer some of these remain as-is. I think the README update is the most important of the set.
I chose not to renameEdit: we included these changes too.bin/src/named.rs, or to update the name of test configs/directories (e.g.tests/test-data/named_test_configs/). If you think those should be renamed as well, I could roll that in :-)Thanks!