Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backtrace dependency. #416

Merged
merged 2 commits into from
Apr 21, 2018
Merged

Remove backtrace dependency. #416

merged 2 commits into from
Apr 21, 2018

Conversation

briansmith
Copy link
Contributor

Disable the default "backtrace" feature of error-chain to remove the
dependency on "backtrace". The replacement for error-chain, the
failure crate, will disable backtraces by default.

Contributed on behalf of Buoyant, Inc.

Signed-off-by: Brian Smith brian@briansmith.org

Disable the default "backtrace" feature of error-chain to remove the
dependency on "backtrace". The replacement for error-chain, the
failure crate, will disable backtraces by default.

Contributed on behalf of Buoyant, Inc.

Signed-off-by: Brian Smith <brian@briansmith.org>
@bluejekyll
Copy link
Member

Thank you. Looks great.

@codecov
Copy link

codecov bot commented Apr 21, 2018

Codecov Report

Merging #416 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #416      +/-   ##
=========================================
+ Coverage   86.26%   86.4%   +0.14%     
=========================================
  Files         133     133              
  Lines       13405   13405              
=========================================
+ Hits        11564   11583      +19     
+ Misses       1841    1822      -19
Impacted Files Coverage Δ
proto/src/tcp/tcp_client_stream.rs 92.4% <0%> (-1.27%) ⬇️
rustls/src/tls_client_stream.rs 100% <0%> (+17.64%) ⬆️
rustls/src/tls_stream.rs 82.85% <0%> (+20%) ⬆️
resolver/src/tls/dns_over_rustls.rs 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b634d...b84ee8e. Read the comment docs.

@bluejekyll bluejekyll merged commit 620b180 into hickory-dns:master Apr 21, 2018
@briansmith briansmith mentioned this pull request Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants