Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ProtoError as a JsValue. #990

Merged
merged 1 commit into from
Jan 12, 2020
Merged

Implement ProtoError as a JsValue. #990

merged 1 commit into from
Jan 12, 2020

Conversation

moshevds
Copy link
Contributor

This improves error handling within WebAssembly modules.

bluejekyll
bluejekyll approved these changes Jan 12, 2020
View reviewed changes
Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the pr!

@bluejekyll bluejekyll merged commit fadc2bd into hickory-dns:master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluejekyll bluejekyll bluejekyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moshevds @bluejekyll