Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support monospace/code in comments #883

Open
adamburgess opened this issue May 8, 2017 · 2 comments
Open

Support monospace/code in comments #883

adamburgess opened this issue May 8, 2017 · 2 comments
Labels
enhancement

Comments

@adamburgess
Copy link

No description provided.

@adamburgess
Copy link
Author

e.g. https://news.ycombinator.com/item?id=14287309

shows as http://i.imgur.com/SK2IZkR.jpg

@hidroh
Copy link
Owner

hidroh commented May 8, 2017

This is the equivalent response via API: https://hacker-news.firebaseio.com/v0/item/14287309.json?print=pretty

Currently the TextView only supports very basic HTML, so we'll probably need some custom parsing in order to display code.

DieBauer added a commit to DieBauer/materialistic that referenced this issue Sep 22, 2018
@DieBauer
Downgrade the html5 <pre><code> tags with html4 <tt>
5a8b5e7 
The textview supports formatting of a few built-in html tags,
`tt` (teletype) is deprecated in html5, but for android this is still implemented

Advantages of this `tt` formatting is that it respects newlines and whitespace,
which makes code formatted comments on Hackernews better readable.

Fixes hidroh#883
DieBauer added a commit to DieBauer/materialistic that referenced this issue Sep 22, 2018
@DieBauer
Downgrade the html5 <pre><code> tags with html4 <tt>
76daa84 
The textview supports formatting of a few built-in html tags,
`tt` (teletype) is deprecated in html5, but for android this is still implemented

Advantages of this `tt` formatting is that it respects newlines and whitespace,
which makes code formatted comments on Hackernews better readable.

Fixes hidroh#883
DieBauer added a commit to DieBauer/materialistic that referenced this issue Sep 22, 2018
@DieBauer
Downgrade the html5 <pre><code> tags with html4 <tt>
78ecbfe 
The textview supports formatting of a few built-in html tags,
`tt` (teletype) is deprecated in html5, but for android this is still implemented

Advantages of this `tt` formatting is that it respects newlines and whitespace,
which makes code formatted comments on Hackernews better readable.

Fixes hidroh#883
@DieBauer DieBauer mentioned this issue Sep 22, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hidroh @adamburgess