Defect introduced in code cleanup commit?

[solind]

I'm seeing the following exception sending really long strings down a ChannelOutputString, which I don't see when using a previous build:

java.lang.ArrayIndexOutOfBoundsException: null
        at net.schmizz.sshj.common.Buffer.putRawBytes(Buffer.java:266)
        at net.schmizz.sshj.connection.channel.ChannelOutputStream$DataBuffer.write(ChannelOutputStream.java:64)
        at net.schmizz.sshj.connection.channel.ChannelOutputStream.write(ChannelOutputStream.java:141)

I looked cursorily and didn't see a problem, but I suspect this might have been broken in commit 636f896.

[hierynomus]

Can you create a unit test that simulates this?

[solind]

I'm super-busy at the moment, but I will give it a shot if you'll point me to an existing unit test that attempts to execute any command over an exec or shell channel.

If you can't, it'll just take me longer to get around to it.

[hierynomus]

Hi David, else do you have some logging and string sizing info for me? Op 9 mrt. 2017 6:37 p.m. schreef "David Solin" <notifications@github.com>:

…

I'm super-busy at the moment, but I will give it a shot if you'll point me to an existing unit test that attempts to execute any command over an exec or shell channel. If you can't, it'll just take me longer to get around to it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#306 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHLowcb-STGA5ryiIsVMuvBfb0Qchqqks5rkDjGgaJpZM4MXcmc> .

[solind]

Hi Jeroen, sorry I never managed to get that unit test working. I just tried this update and it appears fixed to me. Thanks!

[hierynomus]

No problem, the keen eyes of @dkocher found the issue ;)