Ensure that same name subdirs aren't omitted when doing SFTP #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hierynomus We do not depend on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dkocher Could you verify whether CyberDuck relies on the following behaviour and what your preference would be...
Currently when an SFTP copy operation starts, we do a check to see whether the source is a directory, and whether the given destination is a directory of the same name. In that case we copy the contents of the source into the destination. If the names however do not match, we upload the source directory itself into the destination (creating a subdir).
I know we've worked around this in Overthere already (see: https://github.com/xebialabs/overthere/blob/master/src/main/java/com/xebialabs/overthere/ssh/SshSftpFile.java#L143), as the other protocols behave differently. So I was wondering whether we should remove this check, or maybe make it configurable to always upload the contents of the source to the destination.