Added PKCS5 key file support (without requiring BouncyCastle) #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 10, 2016 21:45
Updated StreamCopier class to make it compatible with older SLF4J versions.
Removed BouncyCastle dependency for public key authentication.
Removed 3rd-party JARs from source control Re-introduced original BouncyCastle-dependent PKCS5KeyFile class Re-named non-BouncyCastle-dependent PKCS8KeyFile class to PKCS5KeyFile, since it really only supports PKCS5 formats anyway
…urces to properly differentiate between PKCS5 and PKCS8 file formats.
|
Hi Joval, Thanks for this contribution. As a suggestion, could you split different things up into multiple PRs? The older SLF4J support for instance had no real place in this PR, neither did the additions to the HostEntry interface. Still a great PR though, awaiting your other features! |
|
Yeah, sorry, I'll try to group changes more logically in the future. Thanks for accepting the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing some experimentation with this SSH client, to see if we might leverage it in our project. However, we don't want to add a hard requirement for BouncyCastle just to perform public key authentication.
Therefore, I've implemented a PKCS5KeyFile class that can parse PKCS5 key files. I've also updated the test resource for pkcs8 (as it was actually a pkcs5 file), and updated the test classes as well.
Additional minor modifications I've made permit interoperability with older versions of SLF4J (back to 1.6), and the addition of a few methods to the OpenSSHKnownHosts.HostEntry interface (to make it possible to get the entry type and fingerprint string).
I plan to add a few more features in the coming days.