fix keep-alive thread never be closed #628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TransportImpl have a default serivce as nullService, when you set keepAlive to retain connection, a keep-alive thread will be create and periodic send msg to remote. but even after sshClient.close() has been called. this keepAlive will still exist. So, the solution is to set a ConnectionImpl object to TransportImpl.
|
I'm not sure I understand your comment, or why this should fix it. Can you elaborate? The fix doesn't feel correct... |
|
Superseded by #752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransportImpl have a default serivce as nullService, when you set keepAlive to retain connection, a keep-alive thread will be create and periodic send msg to remote. but even after sshClient.close() has been called. this keepAlive will still exist.
So, the solution is to set a ConnectionImpl object to TransportImpl.