Improve Android compatibility #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only counting BouncyCastle as being registered if it is set as the explicit security provider used by SSHJ, count it as registered if it is available as a provider. This commit improves Android compatibility, which requires not specifying an explicit provider.
|
i'll test the code later, but why check for BC in the first place? why not let it fail? same with the order places where the check for BC happens |
|
hm jitpack doesn't seem to be able to build this edit: i'm getting the same errors. i don't know how to build this so i can't say if this fixes it or not |
|
Let's wait for @hierynomus to give his opinion. My first attempt would also have been to just remove all the explicit BC checks, but I do not know whether this has the potential to obscure bugs. |
The ECNamendCurveGenParameterSpec is a BC-specific workaround for missing curve tables in Java 1.4 and earlier. For the sake of Android compatibility, where Conscrypt can't deal with this custom spec class, replace it with the standard ECGenParameterSpec and update the curve names to the standard identifiers.
fmeum
changed the title
|
I added another commit to fix failing ECDSA key exchanges on Android. |
hierynomus
approved these changes
Oct 20, 2020
|
Would it be possible to get a release with this fix and AES-GCM support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registered if it is available as a provider. This improves Android compatibility, which requires not specifying an explicit provider. This is meant to address Make KeyType compatible with Android Keystore #586 (comment)
@oakkitten Could you verify that this fixes the issue with ECDSA host keys?