Close client connection when remote closes connection + testing (#686) #687
Conversation
tsoiland
changed the title
|
To be clear: the latest commit also contains a fix, not just failing unit test. |
|
I'm not sure that this is actually a problem. You're trying to read a next response without actually doing a next request. The idea of the tunnels is that they're kept open for multiple requests afaik. So it should be possible to do a second GET request over the same tunnel. You can try that with OpenSSH also. |
|
I agree the tunnel should remain open. But the connection going through the tunnel should not. I did use OpenSSH for this before. To be clear, I'm talking about the case where the http server closes the connection between the http server and the remote ssh server. And in such a case I think sshj should close the connection between the local end of the ssh tunnel and the http client. |
|
Can we add a test to prove that the tunnel is not broken :) |
Yes, I'll have a look a it :) |
|
@tsoiland Any luck in adding a test? I want to try to push a new release out end of this week, would be good to have this in. |
Sorry, no. I have it on my todo list, but I'm not expecting to have time for it for at least a few weeks. |
| @@ -132,6 +132,9 @@ public long copy() | |||
| while ((read = in.read(buf)) != -1) { | |||
| count += write(buf, count, read); | |||
| } | |||
|
|
|||
| // Read from in got EOF -> also close out | |||
| out.close(); | |||
There was a problem hiding this comment.
If keepFlushing is false, out.flush will be called after this out.close, and an error will be thrown.
There was a problem hiding this comment.
Agreed. Will have a look at it when I write the unit test requested by hierynomus.
|
@hierynomus See https://github.com/hierynomus/sshj/pull/687/files#diff-b96519fae1fd0022af3205f2062388df9f6d6f3f171f318e83e105c3f0ffaa72R92 for test that proves that tunnel is open and working after http connection is closed. @vladimirlagunov See https://github.com/hierynomus/sshj/pull/687/files#diff-6628369aa60e08c2a181ccae0054fcbec2656b380d89c91b8a3abee7fabb8b64R148-R155 for code that does not close before flush. |
Port forwarding: remote server closes connection, but sshj does not close connection to client