Add PKCS8 parsing for encrypted PEM ASN.1 Private Keys #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added unit tests for encrypted PKCS8 RSA Private Key
hierynomus
approved these changes
Aug 27, 2021
|
Wow, thanks! Good work. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the implementation of PKCS8 parsing support for PEM ASN.1 Private Keys in #708, this pull request adds support for reading and parsing encrypted versions of PEM ASN.1 Private Keys.
This pull request includes unit test updates using a sample encrypted RSA private key, generated using the following command:
This pull request addresses issue #437.