adds fallback to posix-rename@openssh.com extension if possible and c… #827
Conversation
…ommunicates possible problems with flags to the developer
|
|
| // build and send request | ||
| final Request request = newRequest(type); | ||
|
|
||
| if (serverExtension != null) |
There was a problem hiding this comment.
Can you add { around the if-statement... Everywhere where that's not done is a leftover ;)
There was a problem hiding this comment.
Sure, i just pushed a corrected version.
Thanks for your quick reply.
|
Maybe only thing missing is some (unit) tests |
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
============================================
+ Coverage 68.40% 68.55% +0.14%
- Complexity 1398 1412 +14
============================================
Files 207 207
Lines 7478 7504 +26
Branches 631 642 +11
============================================
+ Hits 5115 5144 +29
+ Misses 2025 2015 -10
- Partials 338 345 +7
|
|
I added some simple tests to cover sftp.rename(). |
|
The integration tests run against an OpenSSH server, so that should be testable. |
|
Sorry, I don't have much time at the moment. |
|
The integration tests have been simplified significantly I think. It should not be hard to add a few tests to cover this behaviour now. |
|
I tried to make the tests as future-proof as possible by allowing to request a specific SFTP protocol version. This way things will not break/become non-functional when sshj will support SFTPv5 or greater in the future. |
|
Merged, thanks for the PR! |
|
You're welcome. Thanks for your patience! |
adds fallback to posix-rename@openssh.com extension if possible and communicates possible problems with flags to the developer
Tested with openssh-sftp-server-1:8.9p1-3 (Ubuntu 22.04)