Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AES-GCM Support for OpenSSH Private Keys #899

Merged

Conversation

exceptionfactory
Copy link
Contributor

This pull request adds support for decrypting OpenSSH Version 1 Private Keys encrypted with the following ciphers:

These ciphers require reading an additional authentication tag field from the encoded binary, which the cipher uses for verification.

Additional changes include adding support for the following alternative block cipher algorithm and key size combinations, aligning with OpenSSH ssh-keygen supported ciphers.

  • 3des-cbc
  • aes192-cbc
  • aes128-ctr
  • aes192-ctr

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@a3cce0d). Click here to learn what that means.
The diff coverage is 88.70%.

@@            Coverage Diff            @@
##             master     #899   +/-   ##
=========================================
  Coverage          ?   68.42%           
  Complexity        ?     1401           
=========================================
  Files             ?      207           
  Lines             ?     7475           
  Branches          ?      630           
=========================================
  Hits              ?     5115           
  Misses            ?     2024           
  Partials          ?      336           
Files Coverage Δ
...sshj/userauth/keyprovider/OpenSSHKeyV1KeyFile.java 86.38% <88.70%> (ø)

@hierynomus hierynomus merged commit 9b9b208 into hierynomus:master Oct 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants