Add ChaCha20-Poly1305 Support for OpenSSH Keys #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated ChachaPolyCipher to support decryption without Additional Authenticated Data
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
============================================
- Coverage 68.45% 68.44% -0.02%
+ Complexity 1402 1400 -2
============================================
Files 207 207
Lines 7475 7478 +3
Branches 630 631 +1
============================================
+ Hits 5117 5118 +1
- Misses 2023 2024 +1
- Partials 335 336 +1
|
hierynomus
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the
chacha20-poly1305@openssh.comcipher when decrypting OpenSSH Private Keys.The implementation required adjusting the
ChachaPolyCipher.update()method to accept an input offset of 0, indicating no Additional Authenticated Data included with the encrypted bytes.