Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate product list to Jetpack Compose #177

Closed
hieuwu opened this issue Sep 30, 2023 · 5 comments · Fixed by #190
Closed

Migrate product list to Jetpack Compose #177

hieuwu opened this issue Sep 30, 2023 · 5 comments · Fixed by #190
Assignees
@DeKaN
Labels
good first issue Good for newcomers hacktoberfest

Comments

@hieuwu
Copy link
Owner

hieuwu commented Sep 30, 2023

Currently feature Account in presentation/productlist package is implemented with XML view system. Let's convert it to Jetpack Compose. See shop feature for reference
@DeKaN
Copy link
Contributor

DeKaN commented Sep 30, 2023

Hi, can I take the issue?

@hieuwu
Copy link
Owner Author

hieuwu commented Oct 1, 2023

Hi, can I take the issue?

Sure. I assigned it to you. Let me know if you need any help

@DeKaN
Copy link
Contributor

DeKaN commented Oct 2, 2023

@hieuwu What library do you prefer for loading images in Compose io.coil-kt:coil-compose:2.4.0 or com.github.bumptech.glide:compose:1.0.0-beta01?
I see Glide in the project, but only the first beta for Compose has been released.

@hieuwu
Copy link
Owner Author

hieuwu commented Oct 3, 2023

@hieuwu What library do you prefer for loading images in Compose io.coil-kt:coil-compose:2.4.0 or com.github.bumptech.glide:compose:1.0.0-beta01? I see Glide in the project, but only the first beta for Compose has been released.

I would prefer current one from Glide as it is used. But if you see Coil is better then please go with Coil. Just make sure we can remove the depencency on Glide after using Coil

@DeKaN
Copy link
Contributor

DeKaN commented Oct 3, 2023

OK, I'll try with Glide

@yopilot yopilot mentioned this issue Oct 3, 2023
Merged
DeKaN added a commit to DeKaN/android-groceries-store that referenced this issue Oct 4, 2023
@DeKaN
Migrate product list to Jetpack Compose (fix hieuwu#177)
33b2ffc
DeKaN added a commit to DeKaN/android-groceries-store that referenced this issue Oct 4, 2023
@DeKaN
Migrate product list to Jetpack Compose (fix hieuwu#177)
c288e6f
@DeKaN DeKaN mentioned this issue Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DeKaN DeKaN

Labels
good first issue Good for newcomers hacktoberfest
Projects
Groceries Store
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate product list to Jetpack Compose DeKaN/android-groceries-store
2 participants
@DeKaN @hieuwu