Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/alias knife zero chef_client command #32

Closed
patcon opened this issue Jun 10, 2015 · 5 comments
Closed

Rename/alias knife zero chef_client command #32

patcon opened this issue Jun 10, 2015 · 5 comments
Milestone

Comments

@patcon
Copy link
Contributor

patcon commented Jun 10, 2015

Firstly, amazing great project! So glad it exists, and migrating from chef-solo/knife-solo now.

So yeah, wondering whether another command would be more intuitive, as I didn't realize what the knife zero chef_client QUERY command meant until my second attempt to sort out this plugin :)

I might suggest knife zero converge QUERY, which takes a note from test-kitchen terminology, which many folks know. It's also less alienating for those coming from chef-solo, who might not even really care that chef-client is being run remotely, and are just thinking "I've heard chef-zero is the replacement for chef-solo" (I'll admit this was my mental model, having migrated my test-kitchen and vagrant setups to chef-zero in ignorance, as those tools conveniently hide the complexity of the change)

@sawanoboly
Copy link
Member

Thanks, Test-kitchen is one of my favorite oss (maybe I like than Chef).
When I thought about name of convergence step, I was debating between chef_client and converge.
Then I decided name to chef_client because command which is executed on remote node is chef-client.

But, I'll try to think about alias.

@patcon
Copy link
Contributor Author

patcon commented Jun 11, 2015

Thanks for considering @sawanoboly!

@sawanoboly sawanoboly added this to the v1.6.0 milestone Jun 13, 2015
@sawanoboly
Copy link
Member

@patcon
I'd try to make alias converge to chef_client. How about 8f33e89 ?

@patcon
Copy link
Contributor Author

patcon commented Jun 13, 2015

Looks awesome! I'll start using that branch.

sawanoboly added a commit that referenced this issue Jun 13, 2015
@sawanoboly
Copy link
Member

Released as v1.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants