Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highstock charts ignore redraw flag when removing a series #6363

Closed
LaniMoo opened this issue Feb 11, 2017 · 1 comment
Closed

Highstock charts ignore redraw flag when removing a series #6363

LaniMoo opened this issue Feb 11, 2017 · 1 comment

Comments

@LaniMoo
Copy link

LaniMoo commented Feb 11, 2017

  1. Create a chart with at least 1 series
  2. Remove the series programmatically, with the redraw boolean set to false: series.remove(false)

Behavior:
Chart will ignore redraw boolean and still redraw.

This is due to Highstock also removing the associated series in the navigator without any arguments. You can see in the code snippet below that the removal of the navigator series will always redraw the chart.

                        // Handle series removal
                        addEvent(base, 'remove', function() {
                            if (this.navigatorSeries) {
                                erase(navigator.series, this.navigatorSeries);
                                this.navigatorSeries.remove();
                                delete this.navigatorSeries;
                            }
                        });
@pawelfus pawelfus self-assigned this Feb 20, 2017
pawelfus added a commit that referenced this issue Feb 20, 2017
…eries had a related series in the navigator.
@pawelfus
Copy link
Contributor

Internal note:
Fix causes stock/members:series-remove test to fail, but it's fine (as it compares pixel by pixel with current version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants