Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/14143-14434-stickOnContact-useHTML-outside #15960

Merged

Conversation

khlieng
Copy link
Member

@khlieng khlieng commented Jun 24, 2021

Fixed #14143, #14434, #13310, tooltip with stickOnContact and useHTML or outside enabled did not work properly.

Replaces #14473.
Closes #14434.
Closes #13310.

@khlieng khlieng added the Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. label Jun 24, 2021
@khlieng khlieng self-assigned this Jun 24, 2021
@highsoft-bot highsoft-bot added this to Review in progress in Development-Flow via automation Jun 24, 2021
@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Jun 24, 2021

File size comparison

master candidate difference
highcharts 290.5 kB 290.4 kB -104 B
highcharts, gzipped 97.7 kB 97.6 kB -201 B
highstock 386.6 kB 386.5 kB -104 B
highstock, gzipped 128.7 kB 128.4 kB -300 B
highmaps 349.0 kB 348.9 kB -110 B
highmaps, gzipped 114.6 kB 114.5 kB -30 B
highcharts-gantt 398.1 kB 398.0 kB -106 B
highcharts-gantt, gzipped 132.5 kB 132.3 kB -186 B

@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

@khlieng khlieng force-pushed the bugfix/14143-14434-stickOnContact-useHTML-outside branch from d69ef52 to 41dcf86 Compare July 23, 2021 09:11
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TorsteinHonsi TorsteinHonsi merged commit a548a4b into master Aug 13, 2021
Development-Flow automation moved this from Review in progress to Done Aug 13, 2021
@TorsteinHonsi TorsteinHonsi deleted the bugfix/14143-14434-stickOnContact-useHTML-outside branch August 13, 2021 08:32
@highsoft-bot highsoft-bot added this to the Next milestone Aug 13, 2021
@highsoft-bot highsoft-bot moved this from Done to Review in progress in Development-Flow Aug 13, 2021
@galangel
Copy link

I'm sorry, but it still an issue:

    useHTML: true,
    stickOnContact: true,
    outside: true,

are not working together as expected

for example, here: https://jsfiddle.net/gh/get/library/pure/highcharts/highcharts/tree/master/samples/highcharts/demo/accessible-line

adding outside: true, brakes stickOnContact

@doganalper
Copy link

This is still ongoing issue, can't use stickOnContact with outside configuration.

@khlieng
Copy link
Member Author

khlieng commented Apr 17, 2023

Worked from 9.2.0 to 10.2.1, broken again since 10.3.0, which makes #17781 a likely suspect 🧐 @TorsteinHonsi

@TorsteinHonsi
Copy link
Collaborator

Suspicion confirmed. Bisected to 2e5bdd7.

@TorsteinHonsi
Copy link
Collaborator

@doganalper I'll have a look at this ASAP

@TorsteinHonsi
Copy link
Collaborator

TorsteinHonsi commented Apr 18, 2023

@doganalper , I found a fix, created a PR.

Here's a drop-in workaround that you can use while waiting for the next release:

Highcharts.Pointer.prototype.onContainerMouseLeave = function(e) {

    const { charts, pick, Pointer } = Highcharts;
    const chart = charts[pick(Pointer.hoverChartIndex, -1)];

    e = this.normalize(e);

    // #4886, MS Touch end fires mouseleave but with no related target
    if (
        chart &&
        e.relatedTarget &&
        !this.inClass(e.relatedTarget, 'highcharts-tooltip')
    ) {
        chart.pointer.reset();
        // Also reset the chart position, used in #149 fix
        chart.pointer.chartPosition = void 0;
    }
}

View it live on jsFiddle.

@doganalper
Copy link

@TorsteinHonsi Workaround works perfectly, thank you so much for helping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog.
Projects
Development-Flow
  
Review in progress
5 participants