bugfix/15986-exit-anchor-chart-update #15988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khlieng
added
the
Changelog: Bugfix
File size comparisonNo differences found |
Visual test results - No difference found |
oysteinmoseng
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Nice, good investigative work! The marker is (potentially) recreated on render, so keyboardNavigation.update won't catch it.
The whole end-of-chart-marker logic is a bit messy and probably needs refactoring, but I have it on my list to change the backwards tab navigation logic anyway, so I can clean it up more then.
TorsteinHonsi
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #15986, accessibility exit anchor disappeared on
Chart.update.