Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dash/getoptions-json-serialization #19236

Merged
merged 35 commits into from
Jul 11, 2023
Merged

dash/getoptions-json-serialization #19236

merged 35 commits into from
Jul 11, 2023

Conversation

sebastianbochan
Copy link
Contributor

@sebastianbochan sebastianbochan commented Jun 28, 2023 •
edited
Loading

Added getOptions() method that returns config of dashboard.

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Jun 28, 2023 •
edited
Loading

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
dashboards/dashboards.js 42.1 kB
144.4 kB		 42.3 kB
145.5 kB		 211 B
1128 B
dashboards/modules/dashboards-plugin.js 12.9 kB
39.9 kB		 13.0 kB
40.3 kB		 22 B
353 B

@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

pawellysy and others added 26 commits June 28, 2023 12:06
@pawellysy
Added test for dragging.
0da65d7
@pawellysy
Improved cypress demo.
899fb16
@sebastianbochan
Added updated size of cell after resizing.
cbc3cd3
@pawellysy
Added test to serialization dragging.
4e6c846
@sebastianbochan
Fixed doclets in resizer.
9723902
@sebastianbochan
Added tests to resizer.
40d10fc
@sebastianbochan
Merge pull request #19241 from highcharts/dash/resizer-update-state
51d8367 
dash/resizer-update-state
@pawellysy
Fixed cypress demo.
01ebb9a
@sebastianbochan
Added demo of exporting dashboards to json.
7f54b4a
@sebastianbochan
Added serialization sidebar test.
5ab3d8e
@sebastianbochan
Temporary disabled test for updating component.
7a101c4
@pawellysy
Merge branch 'dash/json-serialization' into dash/serialization-dragging
afd1726
@sebastianbochan
Added readme into demo.
ad5f347
@pawellysy
Merge pull request #19239 from highcharts/dash/serialization-dragging
3032042 
dash/serialization-dragging
@sebastianbochan
Merge pull request #19247 from highcharts/dash/json-serialization-demo
0ddfd1b 
dash/json-serialization-demo
@sebastianbochan
Created test that checks removed cell in json.
eb4a0d7
@sebastianbochan
Fixed conflicts.
f23e87a
@sebastianbochan
Merge pull request #19252 from highcharts/dash/serialization-componen…
6fc6e03 
…t-update-state

dash/serialization-component-update-state
@sebastianbochan
Fixed conflicts.
8699c7c
@sebastianbochan
Merge pull request #19254 from highcharts/dash/serialization-remove-c…
4f57a7c 
…ell-row

dash/serialization-remove-cell-row
@sebastianbochan
Added getOptions function to dashboards.
e3ee033
@sebastianbochan
Merge remote-tracking branch 'origin' into dash/json-serialization
69ff42c
@sebastianbochan
Merge branch 'dash/json-serialization' into dash/getOptions
df4744e
@sebastianbochan
Fixed export to json demo.
83fbb89
@sebastianbochan
Updated paths in export to json demo.
f8f8272
@sebastianbochan
Fixed cypress tests.
f987f50
@sebastianbochan sebastianbochan marked this pull request as ready for review July 7, 2023 08:02
karolkolodziej
karolkolodziej approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@karolkolodziej karolkolodziej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Please consider changing the demo to match the one from the chart- API

ts/Dashboards/Board.ts
* Convert the current state of board's options into JSON. The function does
* not support converting functions or events into JSON object.
*
* @returns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add link to the demo.

@sebastianbochan sebastianbochan changed the title dash/json-serialization dash/getoptions-json-serialization Jul 7, 2023
pawellysy
pawellysy approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@pawellysy pawellysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

bre1470
bre1470 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@bre1470 bre1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good. 👍

pawelfus
pawelfus approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

@sebastianbochan sebastianbochan added the Changelog: Feature Use on PR to add description as a feature in the generated changelog. label Jul 10, 2023
@sebastianbochan sebastianbochan merged commit cdde686 into master Jul 11, 2023
11 checks passed
@highsoft-bot highsoft-bot added this to the Dashboards-Next milestone Jul 11, 2023
@karolkolodziej karolkolodziej deleted the dash/json-serialization branch July 11, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelfus pawelfus pawelfus approved these changes

@pawellysy pawellysy pawellysy approved these changes

@bre1470 bre1470 bre1470 approved these changes

@karolkolodziej karolkolodziej karolkolodziej approved these changes

Assignees
No one assigned
Labels
Changelog: Feature Use on PR to add description as a feature in the generated changelog. Product: Highcharts Dashboards
Projects
None yet
Milestone
Dashboards v1.0.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sebastianbochan @highsoft-bot @pawelfus @pawellysy @bre1470 @karolkolodziej