Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dash/getOptions #19307

Merged
merged 10 commits into from
Jul 6, 2023
Merged

dash/getOptions #19307

merged 10 commits into from
Jul 6, 2023

Conversation

sebastianbochan
Copy link
Contributor

@sebastianbochan sebastianbochan commented Jul 5, 2023 •
edited
Loading

  • - add getOptions on each level
  • - fixed demo
  • - doclets
  • - update tests

@sebastianbochan sebastianbochan changed the base branch from master to dash/json-serialization July 5, 2023 13:49
@sebastianbochan sebastianbochan mentioned this pull request Jul 5, 2023
Merged
17 tasks
@sebastianbochan sebastianbochan changed the base branch from dash/json-serialization to master July 5, 2023 13:53
@sebastianbochan sebastianbochan changed the base branch from master to dash/json-serialization July 5, 2023 13:53
@sebastianbochan sebastianbochan changed the title dash/json-serialization dash/getOptions Jul 5, 2023
@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Jul 5, 2023 •
edited
Loading

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
dashboards/dashboards.js 42.1 kB
144.4 kB		 42.3 kB
145.5 kB		 210 B
1128 B
dashboards/modules/dashboards-plugin.js 12.9 kB
39.9 kB		 13.0 kB
40.3 kB		 23 B
353 B

@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

@sebastianbochan sebastianbochan marked this pull request as ready for review July 5, 2023 15:21
karolkolodziej
karolkolodziej requested changes Jul 6, 2023
View reviewed changes
ts/Dashboards/Board.ts Outdated Show resolved Hide resolved
ts/Dashboards/Board.ts Outdated Show resolved Hide resolved
ts/Dashboards/Components/HTMLComponent.ts Outdated Show resolved Hide resolved
ts/Dashboards/Components/KPIComponent.ts Outdated Show resolved Hide resolved
ts/Dashboards/Layout/Cell.ts Outdated Show resolved Hide resolved
ts/Dashboards/Layout/Layout.ts Outdated Show resolved Hide resolved
@karolkolodziej
Copy link
Contributor

Also TS declaration task fails

pawellysy
pawellysy requested changes Jul 6, 2023
View reviewed changes
ts/Dashboards/Components/Component.ts Show resolved Hide resolved
ts/Dashboards/Layout/Row.ts Outdated Show resolved Hide resolved
ts/Dashboards/Layout/Layout.ts Outdated Show resolved Hide resolved
@sebastianbochan sebastianbochan removed the request for review from bre1470 July 6, 2023 10:29
@sebastianbochan sebastianbochan merged commit bac1b5d into dash/json-serialization Jul 6, 2023
9 checks passed
@karolkolodziej karolkolodziej deleted the dash/getOptions branch January 2, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawellysy pawellysy pawellysy approved these changes

@bre1470 bre1470 bre1470 approved these changes

@karolkolodziej karolkolodziej karolkolodziej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sebastianbochan @highsoft-bot @karolkolodziej @pawellysy @bre1470