Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/17545-funnel-data-labels-inside #20152

Merged
merged 5 commits into from Nov 18, 2023

Conversation

jakubjanuchta
Copy link
Contributor

@jakubjanuchta jakubjanuchta commented Nov 17, 2023

Fixed #17545, misplaced funnel and pyramid data labels after legend item click when dataLabels.inside set to false.

@jakubjanuchta jakubjanuchta self-assigned this Nov 17, 2023
@jakubjanuchta jakubjanuchta added Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. Product: Highcharts labels Nov 17, 2023
@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Nov 17, 2023

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
highcharts.js 96.6 kB
276.6 kB
96.6 kB
276.6 kB
-6 B
-20 B
highstock.js 129.4 kB
378.9 kB
129.4 kB
378.9 kB
-5 B
-20 B
highmaps.js 122.1 kB
355.4 kB
122.1 kB
355.4 kB
-4 B
-20 B
highcharts-gantt.js 131.1 kB
382.4 kB
131.1 kB
382.4 kB
-6 B
-20 B

@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In addtion to my inline question, see https://github.com/highcharts/highcharts/tree/master/changelog#writing-content-for-the-changelog, point 8 about using code backticks.

ts/Extensions/OverlappingDataLabels.ts Outdated Show resolved Hide resolved
@TorsteinHonsi TorsteinHonsi merged commit 0d9c281 into master Nov 18, 2023
11 checks passed
@highsoft-bot highsoft-bot added this to the Next milestone Nov 18, 2023
@TorsteinHonsi TorsteinHonsi deleted the bugfix/17545-funnel-data-labels-inside branch November 18, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. Product: Highcharts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Funnel/Pyramid Chart - Data Labels appear inside indicator even when inside is set to false
3 participants