bugfix/improve-fix-toogling-inverted-packedbubble #20434
Conversation
File size comparisonSizes for compiled+gzipped (bold) and compiled files.
|
hubertkozik
changed the title
Visual test results - No difference found |
ts/Core/Series/Series.ts
Outdated
| series.invertible = seriesTypes[newType].prototype.invertible; | ||
|
|
||
| if (!series.invertible) { | ||
| preserve.splice(preserve.indexOf('invertible'), 1); | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't quite get this. Now that you correctly moved the invertible property to the prototype instead of the instance, I expected this to sort itself out. I expected that we could remove invertible from the preserve array, and every series regardless of update, remove or destroy would have the correct value of invertible from its prototype....
There was a problem hiding this comment.
I've added this code for this kind of situation: https://jsfiddle.net/BlackLabel/ya9sjxLv/ Init load bar chart (inverted) and then update the series to the packedbubble and then update chart to inverted. If you remove those lines, then the invertible in preserve array will take over and the logic will be broken: https://jsfiddle.net/BlackLabel/06zjL4wo/
There was a problem hiding this comment.
And if we remove the invertible from preserve array, then the unit-tests/series-xrange/xrange and unit-tests/chart/chart-update-chart-1 are failing.
There was a problem hiding this comment.
That's because invertible was set on the instance of the Series class, while all others had it in the prototype. Moved it to the prototype and now it seems to pass without the hack: c67581a
TorsteinHonsi
deleted the
bugfix/update-fix-toogling-inverted-packedbubble
branch
Improved
series.invertiblelogic due to failed tests in #20328.