Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/improve-fix-toogling-inverted-packedbubble #20434

Merged
merged 2 commits into from
Jan 16, 2024
Merged

bugfix/improve-fix-toogling-inverted-packedbubble #20434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94550d9
Improved series.invertible logic due to failed tests.
hubertkozik Jan 12, 2024
c67581a
Invertible: Set on the prototype instead of instance
TorsteinHonsi Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ts/Core/Series/Series.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,6 @@ class Series {

public initialType?: string;

public invertible: boolean = true;

public isDirty?: boolean;

public isDirtyData?: boolean;
Expand Down Expand Up @@ -4172,7 +4170,6 @@ class Series {
preserve = [
'colorIndex',
'eventOptions',
'invertible',
'navigatorSeries',
'symbolIndex',
'baseSeries'
Expand Down Expand Up @@ -4871,6 +4868,7 @@ interface Series extends SeriesLike {
colorCounter: number;
directTouch: boolean;
hcEvents?: Record<string, Array<U.EventWrapperObject<Series>>>;
invertible: boolean;
isCartesian: boolean;
kdAxisArray: Array<keyof KDPointSearchObject>;
parallelArrays: Array<string>;
Expand All @@ -4884,6 +4882,7 @@ extend(Series.prototype, {
coll: 'series',
colorCounter: 0,
directTouch: false,
invertible: true,
isCartesian: true,
kdAxisArray: ['clientX', 'plotY'],
// Each point's x and y values are stored in this.xData and this.yData:
Expand Down
3 changes: 1 addition & 2 deletions ts/Series/PackedBubble/PackedBubbleSeries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,6 @@ class PackedBubbleSeries extends BubbleSeries {

public hoverPoint?: PackedBubblePoint;

public invertible = false;

public layout!: PackedBubbleLayout;

public options!: PackedBubbleSeriesOptions;
Expand Down Expand Up @@ -1272,6 +1270,7 @@ extend(PackedBubbleSeries.prototype, {
directTouch: true,
forces: ['barycenter', 'repulsive'],
hasDraggableNodes: true,
invertible: false,
isCartesian: false,
noSharedTooltip: true,
pointArrayMap: ['value'],
Expand Down
16 changes: 1 addition & 15 deletions ts/Series/Pie/PieSeries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,6 @@ class PieSeries extends Series {

public endAngleRad?: number;

public invertible = false;

public options!: PieSeriesOptions;

public points!: Array<PiePoint>;
Expand Down Expand Up @@ -530,31 +528,19 @@ interface PieSeries {
pointClass: typeof PiePoint;
}
extend(PieSeries.prototype, {

axisTypes: [],

directTouch: true,

drawGraph: void 0,

drawTracker: ColumnSeries.prototype.drawTracker,

getCenter: CU.getCenter,

getSymbol: noop,

invertible: false,
isCartesian: false,

noSharedTooltip: true,

pointAttribs: ColumnSeries.prototype.pointAttribs,

pointClass: PiePoint,

requireSorting: false,

searchPoint: noop as any,

trackerGroups: ['group', 'dataLabelsGroup']
});

Expand Down
Loading