New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix/15921-fillcolor-hcm #20703
bugfix/15921-fillcolor-hcm #20703
Conversation
File size comparisonSizes for compiled+gzipped (bold) and compiled files.
|
Visual test results - No difference found |
|
Something interesting going on with mappoint: {
fillColor: 'none'
},
mapline: {
fillColor: 'none'
},
map: {
fillColor: 'none'
} to |
⬆️ added as issue #20716 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I think (if possible) to remove pattern fills and find colors with enough contrast for the demos. You can use white as the color in the top triangle e.g
c12b1e3
to
d3760c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just nitpick!
ts/Accessibility/Accessibility.ts
Outdated
!chart.highContrastModeActive && // Only do this once | ||
whcm.isHighContrastModeActive() | ||
!chart.highContrastModeActive && | ||
!a11yOptions.highContrastMode === false && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a11yOptions.highContrastMode !== false
? (save 1 byte 🥳)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait a minute...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gzip works in mysterious ways.. (But code is easier to read anyway)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixed #15921 by applying
fillColor
to series fromhighContrastTheme.colors
if set.Also introduced
highContrastMode
option to allow disabling/forcing of high contrast mode.WIP Fiddles:
TODO: