-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix/15921-fillcolor-hcm #20703
Merged
Merged
bugfix/15921-fillcolor-hcm #20703
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fbde427
Applied fillColor if colors are provided in HighContrastTheme options
goransle a84351c
Added highContrastMode option
goransle 2e6ad11
Combined if statements
goransle 60ab5a0
Added sample with forced high-contrast-mode
goransle b55431b
Fixed attempting to update undefined points
goransle 23eebd9
Added colorAxis.dataClasses to high contrast theme
goransle d70b39c
Added unit test
goransle d3760c2
Changed colours for series
goransle 2b30840
Saved a whole byte
goransle File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Empty file.
6 changes: 6 additions & 0 deletions
6
samples/highcharts/accessibility/high-contrast-mode/demo.details
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
name: Highcharts - high contrast mode | ||
authors: | ||
- Gøran Slettemark | ||
js_wrap: b | ||
... |
11 changes: 11 additions & 0 deletions
11
samples/highcharts/accessibility/high-contrast-mode/demo.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<script src="https://code.highcharts.com/highcharts.js"></script> | ||
<script src="https://code.highcharts.com/modules/accessibility.js"></script> | ||
|
||
<figure class="highcharts-figure"> | ||
<div id="container"></div> | ||
|
||
<p class="highcharts-description"> | ||
Area chart with high contrast mode enabled and custom colors defined. | ||
</p> | ||
</figure> | ||
|
29 changes: 29 additions & 0 deletions
29
samples/highcharts/accessibility/high-contrast-mode/demo.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
Highcharts.chart('container', { | ||
chart: { | ||
type: 'area' | ||
}, | ||
title: { | ||
text: 'High contrast mode with custom colors' | ||
}, | ||
accessibility: { | ||
highContrastMode: true, // force high contrast mode, | ||
highContrastTheme: { | ||
colors: [ | ||
'#FFFFFF', | ||
'#f9455a', | ||
'#041867' | ||
] | ||
} | ||
}, | ||
series: [ | ||
{ | ||
data: [5, 5, 5, 5, 5, 5] | ||
}, | ||
{ | ||
data: [0, 1, 2, 3, 4, 5] | ||
}, | ||
{ | ||
data: [5, 4, 3, 2, 1, 0] | ||
} | ||
] | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a11yOptions.highContrastMode !== false
? (save 1 byte 🥳)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 / 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait a minute...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gzip works in mysterious ways.. (But code is easier to read anyway)