Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Docs regarding Metrics Reporting #145

Merged
merged 5 commits into from
Jan 18, 2018
Merged

Conversation

juanpedromoreno
Copy link
Member

And also adds an extra-table explaining all the available modules.

@codecov-io
Copy link

codecov-io commented Jan 17, 2018

Codecov Report

Merging #145 into master will decrease coverage by 4.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   92.85%   88.21%   -4.65%     
==========================================
  Files          25       25              
  Lines         266      280      +14     
  Branches        6        6              
==========================================
  Hits          247      247              
- Misses         19       33      +14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e08e3...59467f9. Read the comment docs.


[comment]: # (Start Replace)

```scala
// required for the RPC Server:
libraryDependencies += "io.frees" %% "frees-rpc-server" % "0.9.0"
libraryDependencies += "io.frees" %% "frees-rpc-server" % "0.9.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After PR #146, should this value be 0.10.0 or that value would be changed automatically when we would do the release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be automatically changed 👍

Copy link
Contributor

@eperinan eperinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding job!

@juanpedromoreno juanpedromoreno merged commit 0c549c6 into master Jan 18, 2018
@juanpedromoreno juanpedromoreno deleted the update-docs branch January 18, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants