Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completes the tests and fixes an issue #568

Merged
merged 1 commit into from Mar 4, 2019
Merged

Completes the tests and fixes an issue #568

merged 1 commit into from Mar 4, 2019

Conversation

fedefernandez
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 3, 2019 •
edited

Codecov Report

Merging #568 into feature/jdesiloniz/513-prometheus-implementation will increase coverage by 85.02%.
The diff coverage is 100%.

Impacted file tree graph

@@                                  Coverage Diff                                  @@
##           feature/jdesiloniz/513-prometheus-implementation     #568       +/-   ##
=====================================================================================
+ Coverage                                                 0%   85.02%   +85.02%     
=====================================================================================
  Files                                                    69       69               
  Lines                                                   251     1095      +844     
  Branches                                                  1       11       +10     
=====================================================================================
+ Hits                                                      0      931      +931     
+ Misses                                                  251      164       -87
Impacted Files Coverage Δ
...kindness/mu/rpc/prometheus/PrometheusMetrics.scala 93.33% <100%> (+93.33%) ⬆️
...herkindness/mu/rpc/channel/cache/ClientCache.scala 85.71% <0%> (+85.71%) ⬆️
.../scala/higherkindness/mu/rpc/testing/methods.scala 100% <0%> (+100%) ⬆️
...kindness/mu/rpc/dropwizard/DropWizardMetrics.scala 100% <0%> (+100%) ⬆️
.../higherkindness/mu/rpc/channel/netty/package.scala 100% <0%> (+100%) ⬆️
...gherkindness/mu/task/instances/TaskInstances.scala 100% <0%> (+100%) ⬆️
...a/higherkindness/mu/rpc/config/server/server.scala 50% <0%> (+50%) ⬆️
...a/higherkindness/mu/rpc/interceptors/metrics.scala 100% <0%> (+100%) ⬆️
...erkindness/mu/rpc/internal/client/unaryCalls.scala 100% <0%> (+100%) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b683ba1...c044e65. Read the comment docs.

jdesiloniz
jdesiloniz approved these changes Mar 4, 2019
View reviewed changes
Copy link

@jdesiloniz jdesiloniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!! Thanks a lot!!

@jdesiloniz jdesiloniz merged commit 00a4cad into feature/jdesiloniz/513-prometheus-implementation Mar 4, 2019
@jdesiloniz jdesiloniz deleted the ff/fix-tests branch March 4, 2019 11:48
jdesiloniz pushed a commit that referenced this pull request Mar 12, 2019
Prometheus MetricsOps implementation (#572)
6fb3c1a 
* WIP

* Added basic draft for Prometheus Metrics

* Removing previous prometheus ops class

* Adding implementations for Prometheus methods

* Generalizing generators for both metrics test suites

* WIP tests

* Completes the tests and fixes an issue (#568)

* Adding metrics descriptions

* Unifying tests

* merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdesiloniz jdesiloniz jdesiloniz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fedefernandez @jdesiloniz