Upgrades Project #642
Merged
Upgrades Project #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedefernandez
previously approved these changes
Sep 20, 2019
|
@juanpedromoreno It looks like it has some binary incompatibilities related with fs2 |
|
@fedefernandez I've removed the support for Scala 2.11, as some projects like Circe or http4s in their latest versions did (and the http module cannot cross-compile). |
juanpedromoreno
dismissed
fedefernandez’s stale review
I've done some additional changes after your review. Marked PR as WIP.
|
It's now ready for review 👀 . Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does?
This PR bumps up all the project dependencies to the latest.
Additionally removes the support for Scala 2.11, as some projects like Circe or http4s in their latest versions did (and the
httpmodule cannot cross-compile).In futures PRs we will need to add support for Scala 2.13.
Checklist