Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Reorganization #518

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Conversation

juanpedromoreno
Copy link
Member

This PR reorganizes packages, sbt modules, and directories, as well as it's improving the naming regarding some of the modules.

Regarding modules renaming:

  • mu-rpc-client-core -> mu-rpc-channel: since it's code used in both sides.
  • mu-rpc-client-netty -> mu-rpc-netty
  • mu-rpc-client-okhttp -> mu-rpc-okhttp

Regarding packages:

Everything under package client is now belonging to channel.

Regarding directories:

  • internals contains both internals-fs2 and internals-monix.
  • channel contains both netty and okhttp.

@juanpedromoreno juanpedromoreno added the enhancement New feature or request label Jan 16, 2019
@fedefernandez
Copy link
Contributor

fedefernandez commented Jan 16, 2019

We need to update https://github.com/higherkindness/mu/blob/master/docs/src/main/tut/index.md and other docs too with the new module names.

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #518 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #518   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files          64       64           
  Lines         985      985           
  Branches       19       19           
=======================================
  Hits          802      802           
  Misses        183      183
Impacted Files Coverage Δ
...herkindness/mu/rpc/channel/cache/ClientCache.scala 0% <ø> (ø)
...ess/mu/rpc/channel/ManagedChannelInterpreter.scala 100% <ø> (ø)
...main/scala/higherkindness/mu/client/fs2Calls.scala 75% <ø> (ø)
...erkindness/mu/rpc/config/server/ServerConfig.scala 57.14% <ø> (ø)
.../higherkindness/mu/rpc/channel/netty/package.scala 100% <ø> (ø)
...in/scala/higherkindness/mu/server/monixCalls.scala 89.47% <ø> (ø)
...gherkindness/mu/task/instances/TaskInstances.scala 100% <ø> (ø)
...a/higherkindness/mu/rpc/config/server/server.scala 50% <ø> (ø)
...c/main/scala/higherkindness/mu/MonixAdapters.scala 88.46% <ø> (ø)
...higherkindness/mu/rpc/config/channel/channel.scala 100% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779f630...b2b675e. Read the comment docs.

@juanpedromoreno
Copy link
Member Author

Thanks @fedefernandez , let's update that as part of #511 .

@juanpedromoreno juanpedromoreno merged commit f414d6f into master Jan 16, 2019
@juanpedromoreno juanpedromoreno deleted the jp-renames-client-package-artifacts branch January 16, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants