Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seed sample #598

Merged
merged 14 commits into from Apr 17, 2019

Conversation

Projects
None yet
3 participants
@AdrianRaFo
Copy link
Contributor

commented Apr 12, 2019

Add a new sample to Mu based on:
https://github.com/AdrianRaFo/RPC-Avro-Seed
https://github.com/AdrianRaFo/RPC-Proto-Seed
with the minimal client and server on both avro and protobuf

Update modules/examples/seed/server/modules/process/src/main/scala/ex…
…ample/seed/server/process/AvroPeopleServiceHandler.scala

Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
@codecov

This comment has been minimized.

Copy link

commented Apr 12, 2019

Codecov Report

Merging #598 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #598   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files          62       62           
  Lines         964      964           
  Branches       12       12           
=======================================
  Hits          794      794           
  Misses        170      170

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe5a6f7...a7b2794. Read the comment docs.

Show resolved Hide resolved build.sbt Outdated
Show resolved Hide resolved build.sbt Outdated
Show resolved Hide resolved build.sbt Outdated
Show resolved Hide resolved build.sbt Outdated
Show resolved Hide resolved build.sbt Outdated
Show resolved Hide resolved ...s/examples/seed/server/modules/protocol_avro/src/main/scala/People.scala
Show resolved Hide resolved ...les/seed/server/modules/protocol_avro/src/main/scala/PeopleService.scala
@fedefernandez
Copy link
Collaborator

left a comment

Left some comments but it looks overall. Thanks

Show resolved Hide resolved build.sbt Outdated
Show resolved Hide resolved build.sbt Outdated
Show resolved Hide resolved build.sbt Outdated
Show resolved Hide resolved build.sbt Outdated
Show resolved Hide resolved build.sbt Outdated
Show resolved Hide resolved ...src/main/scala/example/seed/client/process/AvroPeopleServiceClient.scala Outdated
Show resolved Hide resolved ...rc/main/scala/example/seed/client/process/ProtoPeopleServiceClient.scala
Show resolved Hide resolved ...rc/main/scala/example/seed/client/process/ProtoPeopleServiceClient.scala

abstract class ServerBoot[F[_]: ConcurrentEffect] {

def runProgram(args: List[String]): F[ExitCode] =

This comment has been minimized.

Copy link
@fedefernandez

fedefernandez Apr 15, 2019

Collaborator

Same as the client program, you can make ServerBoot extends IOApp and rename this to def run(args: List[String]): IO[ExitCode]

Show resolved Hide resolved ...c/main/scala/example/seed/server/process/ProtoPeopleServiceHandler.scala Outdated

fedefernandez and others added some commits Apr 15, 2019

Update build.sbt
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Update build.sbt
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Update build.sbt
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Update build.sbt
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Update build.sbt
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Update build.sbt
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Update build.sbt
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Update build.sbt
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Update build.sbt
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
@AdrianRaFo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

@fedefernandez @juanpedromoreno ready for a second review

@AdrianRaFo AdrianRaFo merged commit 76afadd into master Apr 17, 2019

4 checks passed

codecov/patch Coverage not affected when comparing fe5a6f7...a7b2794
Details
codecov/project 82.36% remains the same compared to fe5a6f7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@AdrianRaFo AdrianRaFo deleted the arf-add-seed-sample branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.