Add seed sample #598
Merged
Add seed sample #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...er/modules/process/src/main/scala/example/seed/server/process/AvroPeopleServiceHandler.scala
Outdated
Show resolved
Hide resolved
…ample/seed/server/process/AvroPeopleServiceHandler.scala Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
=======================================
Coverage 82.36% 82.36%
=======================================
Files 62 62
Lines 964 964
Branches 12 12
=======================================
Hits 794 794
Misses 170 170Continue to review full report at Codecov.
|
modules/examples/seed/server/modules/protocol_avro/src/main/scala/People.scala
Show resolved
Hide resolved
modules/examples/seed/server/modules/protocol_avro/src/main/scala/PeopleService.scala
Show resolved
Hide resolved
...ent/modules/process/src/main/scala/example/seed/client/process/AvroPeopleServiceClient.scala
Outdated
Show resolved
Hide resolved
...nt/modules/process/src/main/scala/example/seed/client/process/ProtoPeopleServiceClient.scala
Show resolved
Hide resolved
...nt/modules/process/src/main/scala/example/seed/client/process/ProtoPeopleServiceClient.scala
Show resolved
Hide resolved
|
|
||
| abstract class ServerBoot[F[_]: ConcurrentEffect] { | ||
|
|
||
| def runProgram(args: List[String]): F[ExitCode] = |
There was a problem hiding this comment.
Same as the client program, you can make ServerBoot extends IOApp and rename this to def run(args: List[String]): IO[ExitCode]
...r/modules/process/src/main/scala/example/seed/server/process/ProtoPeopleServiceHandler.scala
Outdated
Show resolved
Hide resolved
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>
|
@fedefernandez @juanpedromoreno ready for a second review |
modules/examples/seed/client/modules/app/src/main/resources/application.conf
Outdated
Show resolved
Hide resolved
fedefernandez
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new sample to Mu based on:
https://github.com/AdrianRaFo/RPC-Avro-Seed
https://github.com/AdrianRaFo/RPC-Proto-Seed
with the minimal client and server on both
avroandprotobuf