Provides Empty Message #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 12 12
Lines 122 122
=======================================
Hits 108 108
Misses 14 14Continue to review full report at Codecov.
|
juanpedromoreno
force-pushed
the
feature/frpc-63-empty-requests
branch
from
fda7bd1
to
7c24330
Compare
raulraja
reviewed
Nov 6, 2017
| @@ -38,6 +38,9 @@ package object protocol { | |||
| class message extends StaticAnnotation | |||
|
|
|||
| class option(val name: String, val value: String, val quote: Boolean) extends StaticAnnotation | |||
|
|
|||
| @message | |||
| case class Empty() | |||
There was a problem hiding this comment.
can this be an object Empty instead?
There was a problem hiding this comment.
I'm afraid it cannot be. We need a valid type (serializable) that we could use as request/response type.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Protobuf provides Emtpy, this PR provides an empty type:
freestyle.rpc.protocol.Emptyas generic empty message that you can re-use to avoid defining duplicated empty messages in your APIs. A typical example is to use it as the request or the response type of an API method.For instance:
Fixes #63