Case class Empty is valid for Avro as well #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 12 12
Lines 122 122
=======================================
Hits 108 108
Misses 14 14Continue to review full report at Codecov.
|
raulraja
reviewed
Nov 21, 2017
| @@ -40,7 +40,7 @@ package object protocol { | |||
| class option(val name: String, val value: String, val quote: Boolean) extends StaticAnnotation | |||
|
|
|||
| @message | |||
| case class Empty() | |||
| case class Empty(s: String = "") | |||
There was a problem hiding this comment.
what happens if @message object Empty { val s: String = "" } ?
There was a problem hiding this comment.
It'll be the same case as here, right? But IMHO it deserves a try
juanpedromoreno
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It solves #86 and resolves #79
Finally I added the param
s: String = ""to the existing case class and I created several test for it