Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package and directory structure #40

Closed
L-Lavigne opened this issue Nov 28, 2018 · 3 comments · Fixed by #50
Closed

Improve package and directory structure #40

L-Lavigne opened this issue Nov 28, 2018 · 3 comments · Fixed by #50
Assignees
Labels
enhancement New feature or request

Comments

@L-Lavigne
Copy link
Contributor

Our package structure does not match our directory structure, for example in the file src/main/scala/mu/print.scala:

package skeuomorph
package mu

This causes various inconveniences such as ScalaTest/Specs2 integration in IntelliJ IDEA being unable to identify and run tests together from the src/test root.

We also use chained package declarations which is somewhat non-standard, and it might be worth revisiting that choice.

A re-arrangement of packages would also be a good time to change the package roots once we've agreed internally on a naming convention for higherkindness, as part of #18.

Similar suggestion for mu: higherkindness/mu-scala#480.

@L-Lavigne L-Lavigne added the enhancement New feature or request label Nov 28, 2018
@JesusMtnez
Copy link
Member

@L-Lavigne if I am understanding this correctly, it means moving things to src/main/scala/higherkindness/skeumorph/mu for the example, right?

@JesusMtnez JesusMtnez self-assigned this Dec 5, 2018
@L-Lavigne
Copy link
Contributor Author

That's right, assuming we've agreed on the higherkindness prefix.

As described I'd also like to change the package declarations to the standard style unless we have a good reason to keep the chained style.

@JesusMtnez
Copy link
Member

Perfect then. About the package declarations, I agree on using standard style. There is not any special reason, as far as I know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants