Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support for M1 Macs #559

Closed
ThatScalaGuy opened this issue Jan 2, 2022 · 4 comments
Closed

No support for M1 Macs #559

ThatScalaGuy opened this issue Jan 2, 2022 · 4 comments

Comments

@ThatScalaGuy
Copy link
Contributor

Hi,

protoc-jar is not actively maintained anymore. The community created a PR to add M1 support. But the maintainer is asking for financial sponsorship instead of merging the PR.

In my opinion, a quick fix would be to set the protoc version explicitly. Google provides an M1 build starting from version 3.17 (protoc-jar default 3.14). I think, protoc jar will also look up in the Google repository.
@fedefernandez
Copy link
Contributor

@ThatScalaGuy thanks for the heads up, I'll take a look

ThatScalaGuy pushed a commit to ThatScalaGuy/skeuomorph that referenced this issue Jan 3, 2022
fixed No support for M1 Macs higherkindness#559
29053e2
@ThatScalaGuy
Copy link
Contributor Author

ThatScalaGuy commented Jan 3, 2022 •
edited

@fedefernandez, I created a minor fix. Feel free to use it. If you do a new release soon, I could also fix the mu-scala related stuff.

#560

fedefernandez added a commit that referenced this issue Jan 3, 2022
@ThatScalaGuy @fedefernandez
fixed 'No support for M1 Macs' #559 (#560)
1addf31 
* fixed No support for M1 Macs #559

* Update src/main/scala/higherkindness/skeuomorph/protobuf/ParseProto.scala

Co-authored-by: Sven Herrmann <sven.herrmann@thatscalaguy.d>
Co-authored-by: Fede Fernández <720923+fedefernandez@users.noreply.github.com>
@fedefernandez
Copy link
Contributor

Version 0.1.3 is on its way to maven central. @ThatScalaGuy thanks!

@fedefernandez
Copy link
Contributor

fedefernandez commented Jan 3, 2022 •
edited

@ThatScalaGuy just an update. I've released the last piece of the puzzle (sbt-mu-srcgen) and everything should be fine soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fedefernandez @ThatScalaGuy