Use import root to compile Protobuf files #115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new argument to the
protoc
argument list, that allows finding nested packages when multiple protobuf file imports come from different folders/modules.It's a breaking change for skeuomorph users like
mu-idlgen-sbt
(ifimportRoot
is mandatory, maybe it's a good idea to keep ifOption[String]
and provide a defaultNone
parameter?), that now have to instance aProtoSource
including a common root folder for all proto imports.