Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use import root to compile Protobuf files #115

Merged
merged 6 commits into from Sep 24, 2019
Merged

Conversation

bilki
Copy link
Contributor

@bilki bilki commented Jul 15, 2019

This PR adds a new argument to the protoc argument list, that allows finding nested packages when multiple protobuf file imports come from different folders/modules.

It's a breaking change for skeuomorph users like mu-idlgen-sbt (if importRoot is mandatory, maybe it's a good idea to keep if Option[String] and provide a default None parameter?), that now have to instance a ProtoSource including a common root folder for all proto imports.

Copy link
Member

@pepegar pepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fedefernandez
Copy link
Contributor

@bilki is this still mergeable?

@bilki
Copy link
Contributor Author

bilki commented Sep 18, 2019

It is, but there is another change in mu that needs to be merged too and then bump their dependency version on skeuomorph to the tag where we are going to release this change. Also this needs to be rebased against master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants