New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix readme/microsite #118
Fix readme/microsite #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dzanot
Regarding your question... I'm not completely sure. Currently we're using Do you think we could enhance the process somehow? |
I like the |
@bilki for those examples, I didn't add them I just moved them from one readme to the tut readme. I'll work on making it compile from tut |
I've condensed the protobuf example to mirror the Avro. I'd like to make it a little more complex by adding a service definition but I'm going to have to tinker to get it to work on the avro side. I've also trimmed down the root README, added a link to the microsite, and moved the examples into the docs submodule as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry @dzanot, my fault, didn't know that proto example was already there. Now it looks simpler, more type-secure, and project structure is cleaner now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dzanot ! LGTM on green 👍
Happy to help, CI is all green but I don't have write permissions. Feel free to merge! |
Fixes #117
I just fixed for the current setup, but I have a feeling there's a better way to structure this though.
Maybe moving the tut readme into docs and having thing root readme just link to the microsite?