Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades to droste 0.7.0 #146

Merged
merged 2 commits into from Sep 24, 2019
Merged

Upgrades to droste 0.7.0 #146

merged 2 commits into from Sep 24, 2019

Conversation

juanpedromoreno
Copy link
Member

No description provided.

@juanpedromoreno juanpedromoreno mentioned this pull request Sep 24, 2019
Closed
@BeniVF
Copy link
Contributor

BeniVF commented Sep 24, 2019

@juanpedromoreno I think you need to update the docs

*** Error reported at /home/travis/build/higherkindness/skeuomorph/docs/src/main/tut/optimizations.md:23

<console>:12: error: not found: value qq

       import qq.droste._

              ^

pepegar
pepegar reviewed Sep 24, 2019
View reviewed changes
Copy link
Member

@pepegar pepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

pepegar
pepegar approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@pepegar pepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! ✅ when errs in docs are fixed :D

@BeniVF BeniVF self-requested a review September 24, 2019 08:56
@juanpedromoreno juanpedromoreno merged commit 036743e into master Sep 24, 2019
@juanpedromoreno juanpedromoreno deleted the jp-updates-droste-0.7.0 branch September 24, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepegar pepegar pepegar approved these changes

@BeniVF BeniVF BeniVF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juanpedromoreno @BeniVF @pepegar