Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds twitter-card.png and removes nav title in small size view #182

Merged
merged 2 commits into from Dec 10, 2019
Merged

Adds twitter-card.png and removes nav title in small size view #182

merged 2 commits into from Dec 10, 2019

Conversation

AntonioMateoGomez
Copy link
Contributor

This PR adds twitter-card.pn, poster.png and removes nav title in small size view.

calvellido
calvellido requested changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@calvellido calvellido left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that twitter-card.png file is not necessary since all meta sbt-microsites content refers to the poster.png image, could that be so?

@AntonioMateoGomez AntonioMateoGomez merged commit a674fd2 into master Dec 10, 2019
@AntonioMateoGomez AntonioMateoGomez deleted the paolo-add-twitter-card branch December 10, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

@calvellido calvellido calvellido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AntonioMateoGomez @juanpedromoreno @calvellido