Generate a shapeless Coproduct instead of a placeholder type #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were generating a made-up type `Cop[A :: B :: TNil]`. There is code in the Mu sbt plugin to rewrite it to `A :+: B :+: CNil` using some regex nastiness. We may as well generate a real type in the first place and remove the need for rewriting.
cb372
force-pushed
the
shapeless-coproduct
branch
from
3388277
to
2823373
Compare
juanpedromoreno
approved these changes
Dec 30, 2019
| @@ -103,7 +103,7 @@ class ProtobufProtocolSpec extends Specification with ScalaCheck { | |||
| | @_root_.pbdirect.pbIndex(1) name: _root_.java.lang.String, | |||
| | @_root_.pbdirect.pbIndex(2) books: _root_.scala.Map[_root_.scala.Long, _root_.java.lang.String], | |||
| | @_root_.pbdirect.pbIndex(3) genres: _root_.scala.List[_root_.scala.Option[_root_.com.acme.book.Genre]], | |||
| | @_root_.pbdirect.pbIndex(4,5,6,7) payment_method: Cop[_root_.scala.Long :: _root_.scala.Int :: _root_.java.lang.String :: _root_.com.acme.book.Book :: TNil] | |||
| | @_root_.pbdirect.pbIndex(4,5,6,7) payment_method: _root_.scala.Long :+: _root_.scala.Int :+: _root_.java.lang.String :+: _root_.com.acme.book.Book :+: CNil | |||
There was a problem hiding this comment.
Will we need FQN for :+: as well?
There was a problem hiding this comment.
Good point, there's no reason not to. Same for CNil. That means we can remove some import-generation logic from the sbt plugin as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were generating a made-up type
Cop[A :: B :: TNil]. There is code in the Mu sbt plugin to rewrite it toA :+: B :+: CNilusing some regex nastiness. We may as well generate a real type in the first place and remove the need for rewriting.