Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme skeuomorph example compiles and uses printSchema variable. #21

Merged
merged 1 commit into from Nov 14, 2018

Conversation

rlmark
Copy link
Contributor

@rlmark rlmark commented Nov 14, 2018

Based on the type signature for hylo I think the example should not call .run directly. Also the printSchema variable wasn't used in the example so I added a print out for that. (The change on line 122 is just IntelliJ adding newlines at the end of files that don't have it. Sorry bout the noise!)

Copy link
Member

@pepegar pepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @rlmark, looks good.

But now that you mention it... I think tut was not compiling the README.md file, so no one spotted the error before!

I'll merge this and add an issue to to fix that and get README compiled!

@pepegar pepegar merged commit 1220e44 into master Nov 14, 2018
@pepegar
Copy link
Member

pepegar commented Nov 14, 2018

I've created #22, thanks again @rlmark !

@pepegar pepegar deleted the quick-fix-for-skeuomorph-example branch November 16, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants