Cross compilation Scala 2.13 #236
Conversation
juanpedromoreno
force-pushed
the
cross-scala-2.13
branch
from
cb37a30
to
b09ef12
Compare
juanpedromoreno
force-pushed
the
cross-scala-2.13
branch
from
1026500
to
287a2cf
Compare
juanpedromoreno
force-pushed
the
cross-scala-2.13
branch
from
287a2cf
to
ef177bb
Compare
| - tests | ||
| - deploy | ||
| - microsite | ||
| - test |
There was a problem hiding this comment.
Where are the jobs for this stage defined? I'm also a bit confused by the script above. When does that run?
There was a problem hiding this comment.
Without being an expert, I believe that test is reserved for the script section. TBH, it's the only way I made it work with the help of @fedefernandez .
There was a problem hiding this comment.
Test is the default one, yes. It's a bit confusing though
| case Comparison.CompareBoth(x, y) => Comparison.CompareBoth(f(x), f(y)) | ||
| case Comparison.CompareList(i, rep) => Comparison.CompareList(i.map(f), rep) | ||
| case Comparison.MatchInList(a, rep) => Comparison.MatchInList(a.map(f), rep) | ||
| case Comparison.AlignUnionMembers(a, rep) => Comparison.AlignUnionMembers(a.view.mapValues(_.map(f)).toMap, rep) |
There was a problem hiding this comment.
It took me a while to spot the difference 😄
|
|
||
| package higherkindness.skeuomorph.openapi | ||
|
|
||
| trait OperationHelpers { |
There was a problem hiding this comment.
Rename this file to OperationHelpers.scala ?
| import schema._ | ||
|
|
||
| def operationWithReferences[A](request: Reference, responses: (String, Reference)*): Path.Operation[A] = | ||
| operationFrom(request.asRight.some, responses.toMap.view.mapValues(_.asRight).toMap) |
There was a problem hiding this comment.
Did you try scala-collection-compat? I think it will allow us to write .view.mapValues.toMap in Scala 2.12, so we don't need to duplicate files.
|
@cb372 Thanks for the suggestion! Ready for another look :) CC @BenFradet |
This PR cross-compile the project with Scala 2.13.