Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-github to allow overriding organization #268

Merged
merged 10 commits into from May 1, 2020

Conversation

alejandrohdezma
Copy link
Contributor

What has been done in this PR?

  • Upgrade sbt-github to latest version to allow using githubOrganization to override the organization to 47degrees.
  • Move organization settings to the top of build.sbt as "build" settings.
  • Clean the build a little bit.

@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #268 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #268   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files          29       29           
  Lines        1890     1890           
  Branches       22       22           
=======================================
  Hits         1585     1585           
  Misses        305      305           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6cfe5d...6d5cffa. Read the comment docs.

@@ -1,4 +1,6 @@
import microsites._
ThisBuild / organization := "io.higherkindness"
ThisBuild / githubOrganization := "47degrees"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? shouldn't it be higherkindness?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, since we want to override the organization used for docs and POM to be 47 Degrees

@alejandrohdezma alejandrohdezma changed the title Update sbt-github to allow overriding organizatio Update sbt-github to allow overriding organization Apr 27, 2020
@juanpedromoreno juanpedromoreno merged commit 8e91f36 into master May 1, 2020
@juanpedromoreno juanpedromoreno deleted the override-org branch May 1, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants