-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create partitioned trace_by_id table #7704
Merged
SpennyNDaJets
merged 8 commits into
main
from
spenny/create-partitioned-traces-by-id-mv
Feb 12, 2024
Merged
Create partitioned trace_by_id table #7704
SpennyNDaJets
merged 8 commits into
main
from
spenny/create-partitioned-traces-by-id-mv
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SpennyNDaJets
commented
Feb 8, 2024
backend/clickhouse/migrations/000082_create_new_traces_by_id_mv.up.sql
Outdated
Show resolved
Hide resolved
SpennyNDaJets
requested review from
a team and
mayberryzane
and removed request for
a team
February 8, 2024 20:38
mayberryzane
approved these changes
Feb 12, 2024
Vadman97
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Search multiple traces by id is slow since it needs to search many parts in clickhouse. Create a new table to partition the data by the first character of the UUID
How did you test this change?
traces_by_id
andtraces_by_id_new
table matchAre there any deployment considerations?
Does this work require review from our design team?
N/A