Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create partitioned trace_by_id table #7704

Merged
merged 8 commits into from
Feb 12, 2024

Conversation

SpennyNDaJets
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets commented Feb 8, 2024

Summary

Search multiple traces by id is slow since it needs to search many parts in clickhouse. Create a new table to partition the data by the first character of the UUID

How did you test this change?

  1. Load Clickhouse locally (localhost:8123/play)
  2. Confirm the traces_by_id and traces_by_id_new table match

Are there any deployment considerations?

  1. Deploy to create new table and materialized view
  2. Find latest time stamp and copy over data from old table
  3. Exchange tables

Does this work require review from our design team?

N/A

@SpennyNDaJets SpennyNDaJets marked this pull request as ready for review February 8, 2024 19:24
Copy link

changeset-bot bot commented Feb 8, 2024

⚠️ No Changeset found

Latest commit: 5b10b7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@SpennyNDaJets SpennyNDaJets requested review from a team and mayberryzane and removed request for a team February 8, 2024 20:38
@SpennyNDaJets SpennyNDaJets enabled auto-merge (squash) February 12, 2024 20:26
@SpennyNDaJets SpennyNDaJets merged commit 9ec938d into main Feb 12, 2024
11 checks passed
@SpennyNDaJets SpennyNDaJets deleted the spenny/create-partitioned-traces-by-id-mv branch February 12, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants