-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix text obfuscation logic #7735
Conversation
🦋 Changeset detectedLatest commit: 1e6d457 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall think this is the fix we want. Not sure if we want to include in this PR but from our conversation, we still need to:
- Confirm our edge case
- incremental update through
texts
, only been able to update throughadds
which was working properly - see comment above
- incremental update through
- Add end-to-end tests
better e2e tests coming in https://linear.app/highlight/issue/HIG-4345/e2e-test-for-obfuscation |
Summary
innerHTML changes would not be obfuscated properly in default obfuscation mode.
highlight/rrweb#116
fixes HIG-3970
How did you test this change?
before
after
Are there any deployment considerations?
new changeset
Does this work require review from our design team?
no