Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix text obfuscation logic #7735

Merged
merged 5 commits into from
Feb 14, 2024
Merged

fix text obfuscation logic #7735

merged 5 commits into from
Feb 14, 2024

Conversation

Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Feb 13, 2024

Summary

innerHTML changes would not be obfuscated properly in default obfuscation mode.
highlight/rrweb#116

fixes HIG-3970

How did you test this change?

before
Screenshot from 2024-02-13 09-49-45

after
Screenshot from 2024-02-13 09-54-40

Are there any deployment considerations?

new changeset

Does this work require review from our design team?

no

Copy link

changeset-bot bot commented Feb 13, 2024

🦋 Changeset detected

Latest commit: 1e6d457

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@Vadman97 Vadman97 marked this pull request as ready for review February 13, 2024 17:56
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall think this is the fix we want. Not sure if we want to include in this PR but from our conversation, we still need to:

  • Confirm our edge case
    • incremental update through texts, only been able to update through adds which was working properly
    • see comment above
  • Add end-to-end tests

Copy link

linear bot commented Feb 14, 2024

@Vadman97
Copy link
Member Author

@Vadman97 Vadman97 enabled auto-merge (squash) February 14, 2024 18:47
@Vadman97 Vadman97 merged commit 52b2605 into main Feb 14, 2024
11 checks passed
@Vadman97 Vadman97 deleted the vadim/fix-test-obfuscation branch February 14, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants