Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix text obfuscation logic #116

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix text obfuscation logic #116

merged 1 commit into from
Feb 14, 2024

Conversation

Vadman97
Copy link
Member

No description provided.

@Vadman97 Vadman97 mentioned this pull request Feb 13, 2024
Merged
@Vadman97 Vadman97 marked this pull request as ready for review February 13, 2024 17:57
@Vadman97 Vadman97 merged commit 94d408f into master Feb 14, 2024
4 of 10 checks passed
Vadman97 added a commit to highlight/highlight that referenced this pull request Feb 14, 2024
@Vadman97
fix text obfuscation logic (#7735)
52b2605 
## Summary

innerHTML changes would not be obfuscated properly in default
obfuscation mode.
highlight/rrweb#116

fixes HIG-3970

## How did you test this change?

before
![Screenshot from 2024-02-13
09-49-45](https://github.com/highlight/highlight/assets/1351531/58eb9eea-5d06-442b-aa78-e48df3d57ac9)

after
![Screenshot from 2024-02-13
09-54-40](https://github.com/highlight/highlight/assets/1351531/3584ab82-f042-4bc4-b8ba-22f42154fd09)

## Are there any deployment considerations?

new changeset

## Does this work require review from our design team?

no
Vadman97 added a commit that referenced this pull request Mar 4, 2024
@Vadman97
fix text obfuscation logic (#116)
7355089
Vadman97 added a commit that referenced this pull request Mar 4, 2024
@Vadman97
fix text obfuscation logic (#116)
984a193
Vadman97 added a commit that referenced this pull request Mar 4, 2024
@Vadman97
fix text obfuscation logic (#116)
650776e
Vadman97 added a commit that referenced this pull request Mar 5, 2024
@Vadman97
fix text obfuscation logic (#116)
11a7526
Vadman97 added a commit that referenced this pull request Mar 5, 2024
@Vadman97
fix text obfuscation logic (#116)
7384bca
Vadman97 added a commit that referenced this pull request Apr 16, 2024
@Vadman97
fix text obfuscation logic (#116)
11f2cef
Vadman97 added a commit that referenced this pull request Apr 17, 2024
@Vadman97
fix text obfuscation logic (#116)
7535ca1
Vadman97 added a commit that referenced this pull request Jun 25, 2024
@Vadman97
fix text obfuscation logic (#116)
8e768a0
Vadman97 added a commit that referenced this pull request Jun 25, 2024
@Vadman97
fix text obfuscation logic (#116)
6cf9dd1
Vadman97 added a commit that referenced this pull request Aug 5, 2024
@Vadman97
fix text obfuscation logic (#116)
ed84a25
Vadman97 added a commit that referenced this pull request Aug 5, 2024
@Vadman97
fix text obfuscation logic (#116)
933b357
Vadman97 added a commit that referenced this pull request Aug 5, 2024
@Vadman97
fix text obfuscation logic (#116)
f606a37
Vadman97 added a commit that referenced this pull request Aug 26, 2024
@Vadman97
fix text obfuscation logic (#116)
1e27669
Vadman97 added a commit that referenced this pull request Sep 3, 2024
@Vadman97
fix text obfuscation logic (#116)
004ec2a
Vadman97 added a commit that referenced this pull request Sep 9, 2024
@Vadman97
fix text obfuscation logic (#116)
14fda9b
Vadman97 added a commit that referenced this pull request Sep 18, 2024
@Vadman97
fix text obfuscation logic (#116)
2d109e1
Vadman97 added a commit that referenced this pull request Oct 9, 2024
@Vadman97
fix text obfuscation logic (#116)
f8db7da
Vadman97 added a commit that referenced this pull request Oct 9, 2024
@Vadman97
fix text obfuscation logic (#116)
e862136
Vadman97 added a commit that referenced this pull request Oct 15, 2024
@Vadman97
fix text obfuscation logic (#116)
ae06b8c
Vadman97 added a commit that referenced this pull request Oct 15, 2024
@Vadman97
fix text obfuscation logic (#116)
1df51e5
Vadman97 added a commit that referenced this pull request Oct 29, 2024
@Vadman97
fix text obfuscation logic (#116)
ef527c0
Vadman97 added a commit that referenced this pull request Oct 29, 2024
@Vadman97
fix text obfuscation logic (#116)
9d133b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpennyNDaJets SpennyNDaJets SpennyNDaJets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vadman97 @SpennyNDaJets